Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(RootCollisionHandler): Ignore colliders that are not freepoints #327

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

JucanAndreiDaniel
Copy link
Contributor

Some waypoints begin with FP_ when they are waypoints on the waynet, so we just ignore them as they don't have vobSpotProperties

To Test

  1. change in Scripts/Manager/GvrSceneManager.cs line 71 from GameData.GothicVm.Call("STARTUP_SUB_OLDCAMP"); to GameData.GothicVm.Call("STARTUP_WORLD");
  2. see if errors are thrown regarding rootcollisionhandler

Some waypoints begin with FP_ when they are waypoints on the waynet, so we just ignore them as they don't have vobSpotProperties
@JucanAndreiDaniel JucanAndreiDaniel added the bug Something isn't working label Mar 26, 2024
@JucanAndreiDaniel JucanAndreiDaniel self-assigned this Mar 26, 2024
Copy link
Contributor

@JaXt0r JaXt0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@JucanAndreiDaniel JucanAndreiDaniel merged commit c793117 into main Mar 27, 2024
2 checks passed
@JucanAndreiDaniel JucanAndreiDaniel deleted the bugfix/waypoint-freepoint-fix branch March 27, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants