Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improve settings #262

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Feature/improve settings #262

wants to merge 4 commits into from

Conversation

Romeeey
Copy link
Contributor

@Romeeey Romeeey commented Nov 13, 2023

To test

  1. Start the game
  2. Change movement setting for turntype from snap to continuous turn
  3. Check that continuous turn is on
  4. Go to different map (eg old mine)
  5. Check that continuous turn is still on
  6. Go back to surface map and check that it's still continuous
  7. Change the movement turn type to snap back in the editor (playercontroller gameobject)
  8. Check that the turn type changed ingame

Comments to the code

  • A split between business logic and UI was done.
  • The business logic lies within the PlayerSettingsManager
  • The UI ingame and feature flags reference the PlayerSettingsManger
  • The turntype exists as 2 variables due to the fact that there is the ingame UI, the editor UI and the real static variable
  • Whenever the playercontroller is created (after destroying the old scene and creating the new scene) the settings are loaded from playerprefs
  • OnValidate is restricted to UI changes in the editor (otherwise it would overwrite the playerprefs because it is also called when the script is created and is conflicting with the awake of the playercontroller)
  • Code is old, not merged with main
  • Might be the basis to improve Andrei's music slider implementation

Checklist

(Please judge for yourself which entry is valuable for your PR)

Scene

  • FeatureFlags reverted to right value

Testing

  • Merged main into this branch and tested with the latest features
  • Tested with PCVR
  • Tested with Pico / Quest

Dependencies

  • If libphoenix-shared.dll is changed, .so is also changed

@JaXt0r
Copy link
Contributor

JaXt0r commented Nov 16, 2023

@JucanAndreiDaniel @Romeeey
When shall we test?

@JaXt0r
Copy link
Contributor

JaXt0r commented Nov 21, 2023

@JucanAndreiDaniel @Romeeey still valid branch? If so, please advice next steps. If not, feel free to remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants