Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/30 savegame saving v1 #170

Merged
merged 37 commits into from
Nov 2, 2024
Merged

Feature/30 savegame saving v1 #170

merged 37 commits into from
Nov 2, 2024

Conversation

JaXt0r
Copy link
Contributor

@JaXt0r JaXt0r commented Oct 19, 2024

❗ HINT: Can be reviewed and merged after #169

To test

  • Save and load the game in multiple ways during a session
    • Is hero spawning correct?
    • NPCs doing their job?
    • Are Items where we left them before saving+loading?

Out-of-Scope/Known issues

  • SaveGame menu is always active. So you could potentially hit Save before entering a game and crash it. ;-)
  • Thumbnail of an UnZENity save contains the MainMenu. Something to ignore when creating a screenshot later.

@JaXt0r JaXt0r linked an issue Oct 19, 2024 that may be closed by this pull request
8 tasks
JaXt0r added 29 commits October 19, 2024 10:19
…etter reflect the fact, that they _contain_ other data and object.
…e G1 Classic. TODO: Add all remaining VOB properties.
…s for thousands of objects (instead of removing them when loaded normally).
…re we have VobProperties to store on SaveGame.
# Conflicts:
#	Assets/UnZENity-Core/Scripts/Manager/Scenes/WorldSceneManager.cs
…ashes after a minute or when stopping Unity Editor.
@JaXt0r JaXt0r marked this pull request as ready for review October 30, 2024 03:47
# Conflicts:
#	Assets/UnZENity-Core/Scripts/Manager/Scenes/WorldSceneManager.cs
@JaXt0r
Copy link
Contributor Author

JaXt0r commented Nov 2, 2024

I need this branch for future implementations. I tested it a few times during development. As it's an add -on feature, it's safe to accept.

@JaXt0r JaXt0r merged commit 79f1d2f into main Nov 2, 2024
1 of 2 checks passed
@JaXt0r JaXt0r deleted the feature/30-savegame-saving-v1 branch November 2, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Savegame saving - v1
1 participant