[Tools] Daedalus Language Server article #121
Conversation
| 2. Type `settings.json` and select the option that appears, usually labeled "Preferences: Open User Settings (JSON)". | ||
| 3. Add the following lines at the end of the file (but before `}`), replacing "Windows-1250" with the appropriate code page for your language: | ||
| ```json | ||
| "daedalusLanguageServer.fileEncoding": "Windows-1250", |
There was a problem hiding this comment.
Based on the code it should also allow for a lowercase windows-1250.
https://github.com/kirides/DaedalusLanguageServer/blob/f67a464ffd56fc37c932f456edddf5947b8efe1b/langserver/parseresultsmanager.go#L63
There is also the initial value of 1252 without the windows part 🤔
https://github.com/kirides/DaedalusLanguageServer/blob/f67a464ffd56fc37c932f456edddf5947b8efe1b/langserver/lsphandler.go#L64-L65
Maybe windows1250 could work if 1252 works 😆 I'm sure there is a nice error message if the encoding is unrecognized, but would be nice of Kirides to allow all variants 🥹
There was a problem hiding this comment.
So what should I change in the guide?
There was a problem hiding this comment.
I didn't mark this "review" as a request for changes, you can keep it as-is.
Just an observation for you guys to maybe move upstream to kirides.
From an UX standpoint being able to just set windows1250 everywhere without the - as an exception would be better.
Don't know about DX, as perhaps using same settings between projects is better and the guide depicts some sort of standard in the "Gothic developer space".
There was a problem hiding this comment.
First of all, the plugin should automatically set the encoding of daedalus. It confuse people all the time
There was a problem hiding this comment.
Looks like Auronen tried to do something with that: kirides/vscode-daedalus#9
No description provided.