Update google-cloud-auth to drop [email protected] #3591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[email protected] doesn't build on ppc and risc-v, and updating google-cloud-auth pulls in a newer version of jsonwebtoken, which in turn depends on a newer version of ring that we depend on already either way.
|
Ah, oh, I see. MSRV is 1.70.0 which is not supported for these updated deps anymore... |
|
I'm happy to bump the MSRV, given a reason. What version is required? |
|
It would be 1.73.0 |
|
That sounds fine. |
|
I'll package cargo xtask for chimera linux later then and go ahead and do that :D |
|
It should just run within the repo where you're making the PR |
|
Indeed, somehow I don't need cargo-xtask installed. Still, it doesn't do it: |
|
My short dig seems to point to the xtask being lost when taskchampion got moved out of the taskwarrior repo? |
djmitche
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[email protected] doesn't build on ppc and risc-v, and updating
google-cloud-auth pulls in a newer version of jsonwebtoken,
which in turn depends on a newer version of ring that we depend on
already either way.
Readable "diff":
Chimera Linux has been carrying a patch that contained the changes made by
cargo updatefor a while. I've reduced that patch because I'm not sure whether a broadcargo updateis even wanted.In my opinion it would make sense to bump all dependencies to their latest compatible versions before each release using
cargo update, and maybe even to runcargo upgrade --incompatibleevery now and then to get the latest and greatest. That last one some times causes more work though, as it also includes breaking changes of dependencies.