-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Refactor Benzina #29
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the way back in #2 it was added a small ad-hoc library named Benzina with a simple, two piece, concept:
StreamInterface
.PumpInterface
.Benzina allows us to load data batches of n records from the tables in the old Goteo v3 database and feed them to available (i.e: they support the data in the table records) Pumps that transform the data into v4 entities and stores it in the Goteo v4 database.
But after several heavy work done on v4, Benzina had been left unattended and fallen outdated, as the implemented Pumps had fallen out of sync with the usage of the entities they were meant to pump data to and the library was also remarkably slow and memory-hungry.
Heavy profiling was performed on the library and the following issues were brought to light and then fixed:
DoctrinePumpTrait::skipPumped
which returns the input batch minus the already-pumped records in the batch. This allows to reduce associated pumped data lookups for the batch such as users and projects by allowing the pump to only work with un-pumped data in a batch, effectively skipping already-pumped data from all processes.