Update puppeteer #13677
Closed
Update puppeteer #13677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plugin builds for e3466b9 are ready 🛎️!
|
|
Size Change: +8.24 kB (+0.3%) Total Size: 2.77 MB
ℹ️ View Unchanged
|
swissspidy
reviewed
May 16, 2024
swissspidy
reviewed
May 16, 2024
swissspidy
reviewed
May 16, 2024
swissspidy
reviewed
May 16, 2024
swissspidy
reviewed
May 16, 2024
swissspidy
reviewed
May 16, 2024
packages/e2e-test-utils/package.json
Outdated
| @@ -27,7 +27,7 @@ | |||
| "main": "./src/index.js", | |||
| "dependencies": { | |||
| "@wordpress/url": "^3.48.0", | |||
| "expect-puppeteer": "^9.0.1" | |||
| "expect-puppeteer": "^9.0.2" | |||
There was a problem hiding this comment.
The latest version is 10.0.0
There was a problem hiding this comment.
This was added automatically after running npm update expect-puppeteer. Should I update the version manually?
There was a problem hiding this comment.
Yes in that case manually would be fastest. npm update also looks at dependencies and their requirements etc.
Since Puppeteer updates involve a few packages, it's usually easiest to manually update the version numbers in package.json and then run npm i
swissspidy
reviewed
May 16, 2024
packages/e2e-tests/package.json
Outdated
| @@ -31,7 +31,7 @@ | |||
| "@web-stories-wp/jest-resolver": "*", | |||
| "@wordpress/jest-console": "^7.18.0", | |||
| "babel-jest": "^29.5.0", | |||
| "expect-puppeteer": "^9.0.1", | |||
| "expect-puppeteer": "^9.0.2", | |||
There was a problem hiding this comment.
The latest version is 10.0.0
jest-environment-puppeteer is at 10.0.1
swissspidy
reviewed
May 16, 2024
package.json
Outdated
| @@ -156,7 +156,7 @@ | |||
| "postcss-styled-syntax": "^0.6.4", | |||
| "postcss-syntax": "^0.36.2", | |||
| "prettier": "^3.2.4", | |||
| "puppeteer": "^21.9.0", | |||
| "puppeteer": "^21.11.0", | |||
swissspidy
reviewed
May 17, 2024
package.json
Outdated
| @@ -156,8 +156,8 @@ | |||
| "postcss-jsx": "^0.36.4", | |||
| "postcss-styled-syntax": "^0.6.4", | |||
| "postcss-syntax": "^0.36.2", | |||
| "puppeteer": "^22.9.0", | |||
There was a problem hiding this comment.
The order is incorrect now
There was a problem hiding this comment.
Yes, I noticed that, I'll push a fix for it. I was looking at the E2E tests, and saw a lot of TypeError: page.waitForTimeout is not a function.
There was a problem hiding this comment.
Yeah I had fixed those in #13612
but the failing taxonomies tests are annoying..maybe we just have to skip those for now
|
As I feared, the same error happens as in #13612... 😢 Also, might need to cherry pick some of the fixes I did in that PR because Puppeteer did some API changes. |
This was removed in Puppeteer v22 (cherry picked from commit ef439a2)
|
Sadly, this looks like quite the rabbit hole 😞 Closing this for now until we figure out a good way to address this. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #