Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement speculative prerendering #13616
Implement speculative prerendering #13616
Changes from 33 commits
7d3ccaf
6fbdbe7
b11a77a
99052d6
25db67a
b652865
54990f5
ace9622
68a6acf
7c9ba61
d6f2216
1967e6c
d7342b9
737b6f5
0d13e6a
afd008c
289baa4
d77c251
da1f746
e0c6b9f
0b9256b
6ee4302
f4c9750
e85b4dc
8ac8d38
cbe2537
7e09c83
354e306
118cc79
4d65d2e
c5e54c0
55ca62f
5b558a6
b948dc1
566a73f
7d1c4ff
0af6756
56f19cf
18199a4
33b5c38
30361eb
422dd67
f6f99e4
7922abb
7bbc544
4706bbb
6dfe9ce
d3a49d0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add
$view_story_url
here too so that links to the story permalink can be preloaded.We should also test whether
$view_story_url
should be inprefetch
instead, notprerender
, given that it's usually loaded in a lightbox anyway.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested both
prefetch
andprerender
for$view_story_url
, and I couldn't see a noticeable difference. Prerender appeared to be just slightly faster, in terms of page loading times.Check failure on line 74 in tests/phpunit/integration/tests/Speculation_Rules.php
GitHub Actions / PHP 8.1 - WP latest
Check failure on line 74 in tests/phpunit/integration/tests/Speculation_Rules.php
GitHub Actions / PHP 8.0 - WP latest
Check failure on line 74 in tests/phpunit/integration/tests/Speculation_Rules.php
GitHub Actions / PHP 7.4 - WP 6.3
Check failure on line 74 in tests/phpunit/integration/tests/Speculation_Rules.php
GitHub Actions / PHP 8.2 - WP latest (experimental) (in random order)
Check failure on line 74 in tests/phpunit/integration/tests/Speculation_Rules.php
GitHub Actions / PHP 8.3 - WP trunk (experimental)
Check failure on line 74 in tests/phpunit/integration/tests/Speculation_Rules.php
GitHub Actions / PHP 8.4 - WP trunk (experimental)