Improve captions appearance when there is also a CTA #13477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…grid-layer` `amp-story-captions` adds caption in shadow-dom. Thus, parent `div` container of the `amp-story-captions` won't reflect the actual size of the `amp-story-captions`. This will fix this issue by setting `max-height` of the `amp-story-grid-layer.align-bottom` exactly to the shadow-dom component. Additionally, fixed-height layout of the `amp-story-captions` is changed to container in order to occupy only required space.
AnuragVasanwala
added
Type: Bug
|
Any thoughts on trying out |
This won't fix overlay issue because I will provide in depth analysis and fix on the PR by adding detailed video GIFs representing issue and how it's been fixed. Correct me if I have missed something. |
@swissspidy I tried
May we go with [2.1] approach? |
swissspidy
reviewed
Oct 27, 2023
|
Interesting! Thanks for sharing the various options, much appreciated! Let's try [2.1] indeed 👍 |
|
Plugin builds for 292eb55 are ready 🛎️!
|
|
Size Change: +29 B (0%) Total Size: 2.75 MB ℹ️ View Unchanged
|
|
Note that two snapshot tests in And that one Karma test is just flakey. Maybe we can make it more robust at some point. |
swissspidy
changed the title
swissspidy
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of the PR is to fix layout of the video subtitles (when present) so that they won't display below CTA button.
Summary
amp-story-captionsadds caption in shadow-dom. Thus, parentdivcontainer of theamp-story-captionswon't reflect the actual size of theamp-story-captions.This will fix this issue by setting
max-heightof theamp-story-grid-layer.align-bottomexactly to the shadow-dom component.Additionally, fixed-height layout of the
amp-story-captionsis changed to container in order to occupy only required space.User-facing changes
Not applicable.
Testing Instructions
Follow #13425 for the testing instruction.
Reviews
Does this PR have a security-related impact?
No.
Does this PR change what data or activity we track or use?
No.
Does this PR have a legal-related impact?
No.
Checklist
Type: XYZlabel to the PRFixes #13425