Skip to content

Commit

Permalink
Install puppeteer using npm still
Browse files Browse the repository at this point in the history
See oven-sh/bun/#4705
  • Loading branch information
swissspidy committed Sep 19, 2023
1 parent bbd5934 commit 170e0ba
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 2 deletions.
8 changes: 7 additions & 1 deletion .github/workflows/tests-karma-dashboard.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,17 @@ jobs:
- name: Setup Bun
uses: oven-sh/setup-bun@a1800f471a0bc25cddac36bb13e6f436ddf341d7

- name: Setup Node
uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d
with:
node-version-file: '.nvmrc'
cache: npm

# TODO: Remove need for `npm install puppeteer`.
- name: Install dependencies
run: |
bun install
bun install puppeteer
npm install puppeteer
env:
PUPPETEER_PRODUCT: chrome

Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/tests-karma-editor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,17 @@ jobs:
- name: Setup Bun
uses: oven-sh/setup-bun@a1800f471a0bc25cddac36bb13e6f436ddf341d7

- name: Setup Node
uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d
with:
node-version-file: '.nvmrc'
cache: npm

# TODO: Remove need for `npm install puppeteer`.
- name: Install dependencies
run: |
bun install
bun install puppeteer
npm install puppeteer
env:
PUPPETEER_PRODUCT: chrome

Expand Down

0 comments on commit 170e0ba

Please sign in to comment.