Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add kaniko.imagePullSecret config option for pulling kaniko images from private registry #9183

Closed
wants to merge 0 commits into from

Conversation

dherges
Copy link

@dherges dherges commented Nov 21, 2023

Fixes: #9170
Related: n/a
Merge before/after: n/a

Description

add a new config option kaniko.imagePullSecret

Do you reach out if there is anything missing?

@dherges dherges requested a review from a team as a code owner November 21, 2023 07:48
@dherges dherges requested a review from bendory November 21, 2023 07:48
@dherges dherges changed the title feat: feat: add kaniko.imagePullSecret config option for pulling kaniko images from private registry Nov 21, 2023
@ericzzzzzzz
Copy link
Contributor

Hi @dherges Thank you for the contribution , could you please have a separate pr just for the config schema change ? Thanks

@dherges
Copy link
Author

dherges commented Nov 21, 2023

Hi @dherges Thank you for the contribution , could you please have a separate pr just for the config schema change ? Thanks

Do you mean the hack/new-version.sh + the 2 lines added to config.go?

@ericzzzzzzz
Copy link
Contributor

Hi @dherges Thank you for the contribution , could you please have a separate pr just for the config schema change ? Thanks

Do you mean the hack/new-version.sh + the 2 lines added to config.go?
There are two commits in this pr, you should split this pr into two pr, one for new config schema generation, another for the business logic change. Please follow the guide here , https://github.com/GoogleContainerTools/skaffold/blob/main/DEVELOPMENT.md#making-a-config-change , thanks.

@dherges
Copy link
Author

dherges commented Nov 23, 2023

Hi @dherges Thank you for the contribution , could you please have a separate pr just for the config schema change ? Thanks

Do you mean the hack/new-version.sh + the 2 lines added to config.go?
There are two commits in this pr, you should split this pr into two pr, one for new config schema generation, another for the business logic change. Please follow the guide here , https://github.com/GoogleContainerTools/skaffold/blob/main/DEVELOPMENT.md#making-a-config-change , thanks.

I closed this.

For the config option: #9190

The implementation #9191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kaniko in-cluster build: pulling kaniko images from private registry w/ image pull secret
2 participants