This repository has been archived by the owner on Oct 27, 2022. It is now read-only.
add support for Cloud Build config (resolve #8) #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaketramDurbha
requested review from
dmahugh,
jsimonweb,
kurtisvg and
danielylee01
SaketramDurbha
commented
Aug 18, 2020
SaketramDurbha
commented
Aug 18, 2020
internal/cmd/cmd.go
Outdated
| "log" | ||
| "os/exec" | ||
| "path/filepath" | ||
| ) | ||
|
|
||
| // InitConfig initializes binds command line flags and environment variables to viper configuration keys. This should |
There was a problem hiding this comment.
This is also a placeholder for @danielylee01 's work, to be built off of this PR: #22
kurtisvg
suggested changes
Aug 18, 2020
kurtisvg
approved these changes
Aug 20, 2020
SaketramDurbha
requested review from
grayside and
tritone
and removed request for
tritone
added 14 commits
August 22, 2020 02:45
SaketramDurbha
force-pushed
the
cloud-build-config
branch
from
3565e2c to
7e45dc9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue resolves Issue #8.
Currently set up with making a mandatory substitution
_SST_RUN_REGIONfor passing the Cloud Run region to the Cloud Build config file, but this is open to being changed.Will rebase and update once PR #22 is merged.