Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(samples): upgrade rails 7 for ruby samples #1173

Merged
merged 25 commits into from
Sep 22, 2023
Merged

chore(samples): upgrade rails 7 for ruby samples #1173

merged 25 commits into from
Sep 22, 2023

Conversation

shivgautam
Copy link
Contributor

@shivgautam shivgautam commented Sep 19, 2023 •
edited by SandeepTuniki
Loading

PR 1 for issue #1172

@shivgautam
chore(samples): first pass of upgrades for few samples
7ec060a
@shivgautam
chore(samples): fixing rubocop issues
4ddb939
@shivgautam
chore(samples): changes for 2 more samples
15fed02
@shivgautam
chore(samples): next set of few components
e02c531
@shivgautam
chore(samples): getting started grpc update
06a88d1
@shivgautam
chore(samples): updates for metadata server
11c11e0
@shivgautam
chore(samples): more metadata server changes
117ec31
@shivgautam
chore(samples): pubsub dependency updates
86aaa4e
@shivgautam
chore(samples): updated dependencies for storage
340c4f7
@shivgautam
chore(samples): updated dependencies for static files
57006c3 
sinatra & websockets
@shivgautam
chore(samples): updated dependencies for hello world
a16a8b8
@shivgautam
chore(samples): dependency updates for auth
4020eb9
@shivgautam
chore(samples): updated dependencies for iap & jobs
69c066c
@shivgautam
chore(samples): replacing poltergeist with cuprite
ab59b49
@shivgautam
Merge branch 'main' into replace_poltergeist_with_cuprite
2e89261
@shivgautam
chore(samples): updated few components to rails 7
222538a
@shivgautam
Merge branch 'main' into upgrade_rails7_for_ruby_samples
950c500
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 19, 2023
@shivgautam shivgautam added the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 19, 2023
@shivgautam shivgautam self-assigned this Sep 19, 2023
@shivgautam shivgautam added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 19, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 19, 2023
@shivgautam shivgautam marked this pull request as ready for review September 19, 2023 07:41
@shivgautam shivgautam requested review from a team as code owners September 19, 2023 07:41
@shivgautam shivgautam added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 19, 2023
dazuma
dazuma requested changes Sep 19, 2023
View reviewed changes
Copy link
Member

@dazuma dazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has got to have been really tedious. Thanks for doing this!

appengine/rails-cloudsql-mysql/app/assets/images/dummy Outdated Show resolved Hide resolved
appengine/rails-cloudsql-mysql/Gemfile.lock Outdated Show resolved Hide resolved
@shivgautam shivgautam requested a review from a team as a code owner September 20, 2023 03:51
@shivgautam shivgautam removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 22, 2023
@shivgautam shivgautam merged commit 4c30974 into main Sep 22, 2023
6 checks passed
@shivgautam shivgautam deleted the upgrade_rails7_for_ruby_samples branch September 22, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dazuma dazuma dazuma approved these changes

@SandeepTuniki SandeepTuniki SandeepTuniki approved these changes

Assignees

@shivgautam shivgautam

Labels
samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shivgautam @dazuma @SandeepTuniki @kokoro-team