-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add Cloud Spanner OC client metrics sample #6515
Conversation
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
LGTM other than maybe missing tests. However, given that the Spanner samples have been moved to |
Hi Chris! Could you move this sample to the python-spanner repo? It also might be a good idea to put a placeholder here to let people know where to look. See example here. |
Closing in favor of googleapis/python-spanner#568. |
Description
This PR addresses #6514, adds a sample for capturing Cloud Spanner gRPC metrics with OpenCensus.
Note that we need to do extra work to instrument gRPC to emit the stats we're collecting here. We may want to wait to merge this PR or include this in public docs until we make the required gRPC changes.
FYI @larkee you're the owner of
/spanner/**/*.py
in CODEOWNERS, let me know if you want me to add a separate entry for OC samples and make myself the owner.cc @mayurkale22
Checklist
nox -s py-3.6
(see Test Environment Setup)nox -s lint
(see Test Environment Setup)These samples need a new API enabled in testing projects to pass (let us know which ones)These samples need a new/updated env vars in testing projects set to pass (let us know which ones)This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample