Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Cloud Spanner OC client metrics sample #6515

Closed
wants to merge 5 commits into from

Conversation

c24t
Copy link
Contributor

@c24t c24t commented Aug 4, 2021

Description

This PR addresses #6514, adds a sample for capturing Cloud Spanner gRPC metrics with OpenCensus.

Note that we need to do extra work to instrument gRPC to emit the stats we're collecting here. We may want to wait to merge this PR or include this in public docs until we make the required gRPC changes.

FYI @larkee you're the owner of /spanner/**/*.py in CODEOWNERS, let me know if you want me to add a separate entry for OC samples and make myself the owner.

cc @mayurkale22

Checklist

@c24t c24t requested review from larkee and a team as code owners August 4, 2021 01:19
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 4, 2021
@snippet-bot
Copy link

snippet-bot bot commented Aug 4, 2021

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 4, 2021
@larkee
Copy link
Contributor

larkee commented Aug 9, 2021

LGTM other than maybe missing tests.

However, given that the Spanner samples have been moved to googleapis/python-spanner I'm wondering if this is the right place for this sample.

@dinagraves
Copy link
Contributor

dinagraves commented Aug 13, 2021

Hi Chris! Could you move this sample to the python-spanner repo? It also might be a good idea to put a placeholder here to let people know where to look. See example here.

@parthea parthea assigned c24t and unassigned dinagraves Aug 14, 2021
@parthea parthea changed the title Add Cloud Spanner OC client metrics sample chore: Add Cloud Spanner OC client metrics sample Aug 14, 2021
@c24t
Copy link
Contributor Author

c24t commented Sep 13, 2021

Closing in favor of googleapis/python-spanner#568.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants