Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts TF tests to use Keras 2 instead of 3 #1014

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

EricLeFort
Copy link
Collaborator

Description

  • Keras 3 breaks tests but this change reverts the tests to use Keras 2 instead

Tests

I ran on resnet v4-8 func. The test is still failing but it's clearing the Keras issue and making it further than it was previously.

Instruction and/or command lines to reproduce your tests:
./scripts/run-oneshot.sh -t tf.nightly-resnet-imagenet-func-v4-8-1vm

List links for your tests (use go/shortn-gen for any internal link):
http://shortn/_BFfQJMT0mS

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • [ X ] I have performed a self-review of my code.
  • [ X ] I have necessary comments in my code, particularly in hard-to-understand areas.
  • [ X ] I have run one-shot tests and provided workload links above if applicable.
  • [ X ] I have made or will make corresponding changes to the doc if needed.

@EricLeFort EricLeFort merged commit 187d2ac into master Nov 16, 2023
5 checks passed
@EricLeFort EricLeFort deleted the keras-2-fix branch November 16, 2023 00:39
@EricLeFort EricLeFort restored the keras-2-fix branch November 28, 2023 21:44
@EricLeFort EricLeFort deleted the keras-2-fix branch November 28, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants