Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hf-diffusers.libsonnet checkpoint steps to skip save checkpoints #1001

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ManfeiBai
Copy link
Collaborator

@ManfeiBai ManfeiBai commented Oct 3, 2023

Description

Update hf-diffusers.libsonnet checkpoint steps to skip save checkpoints

Tests

Please describe the tests that you ran on TPUs to verify changes.

Instruction and/or command lines to reproduce your tests:
./scripts/run-oneshot.sh -t pt-2.1-hf-diffusers-conv-v4-8-1vm

List links for your tests (use go/shortn-gen for any internal link):
./scripts/run-oneshot.sh -t pt-2.1-hf-diffusers-conv-v4-8-1vm: http://shortn/_XUJnu7W1FP

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run one-shot tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

@wonjoolee95
Copy link
Collaborator

Just to get back on track, what was the reason for this change?

@ManfeiBai
Copy link
Collaborator Author

Just to get back on track, what was the reason for this change?

The reason of this change is to make the test green, but we are trying to debug the reason of saving checkpoint hang locally too now

@wonjoolee95
Copy link
Collaborator

Just to get back on track, what was the reason for this change?

The reason of this change is to make the test green, but we are trying to debug the reason of saving checkpoint hang locally too now

Right, to rephrase my question, it was asking the reason why we need to update the checkpoint steps to make the test green. But seems like the investigation is TBD, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants