Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clone aotc and get metrics from gcs and set pythonpath #500

Merged
merged 21 commits into from
Dec 11, 2024
Merged

clone aotc and get metrics from gcs and set pythonpath #500

merged 21 commits into from
Dec 11, 2024

Conversation

gunjanj007
Copy link
Collaborator

@gunjanj007 gunjanj007 commented Dec 6, 2024 •
edited
Loading

Description

Please include a summary of relevant context/issue and your changes.

Tests

Please describe the tests that you ran on Cloud VM to verify changes.

Instruction and/or command lines to reproduce your tests: ...

List links for your tests (use go/shortn-gen for any internal link): ...

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run one-shot tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

polydier1
polydier1 reviewed Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@polydier1 polydier1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

polydier1
polydier1 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@polydier1 polydier1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still have question about one comment, please resolve them before merging.

@gunjanj007 gunjanj007 merged commit ba15428 into master Dec 11, 2024
6 checks passed
@gunjanj007 gunjanj007 deleted the gunjanj branch December 11, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polydier1 polydier1 polydier1 approved these changes

@mbzomowski mbzomowski mbzomowski approved these changes

@RissyRan RissyRan Awaiting requested review from RissyRan RissyRan is a code owner

@allenwang28 allenwang28 Awaiting requested review from allenwang28 allenwang28 is a code owner

@cleop-google cleop-google Awaiting requested review from cleop-google

@crankshaw-google crankshaw-google Awaiting requested review from crankshaw-google crankshaw-google is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gunjanj007 @mbzomowski @polydier1