Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create mlcompass_maxtext_gke dag #485

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

ortibazar
Copy link
Collaborator

@ortibazar ortibazar commented Nov 21, 2024

Description

Add MLCompass MaxText GKE runner for deploying and executing MaxText models, and add a skip_prost_process parameter to the xlml/apis/task to allow workflows bypass post-processing tasks.

Tests

Please describe the tests that you ran on Cloud VM to verify changes.

Instruction and/or command lines to reproduce your tests: ...

  blaze build -c opt third_party/mlcompass/executors/runners:tf_runner
  blaze-bin/third_party/mlcompass/executors/runners/tf_runner \
    --config_path=xlml/xlml_dev.pbtxt \
    --benchmark_ids=1 \
    --xlml_environment_name=orti-test \
    --xlml_dag_name=mlcompass_maxtext_gke \
    --xlml_build_docker_image=true \
    --alsologtostderr

List links for your tests (use go/shortn-gen for any internal link): ...
https://a2ca3cdf681d42a3aceb01b7d66a6681-dot-us-central1.composer.googleusercontent.com/dags/mlcompass_maxtext_gke/grid?dag_run_id=manual__2024-11-21T18%3A04%3A51%2B00%3A00

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run one-shot tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

Copy link
Contributor

@mbzomowski mbzomowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a description for this PR

dags/mlcompass/maxtext_gke.py Outdated Show resolved Hide resolved
xlml/apis/task.py Show resolved Hide resolved
@ortibazar
Copy link
Collaborator Author

Please add a description for this PR

Done

@ortibazar ortibazar merged commit d9a509c into GoogleCloudPlatform:master Dec 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants