Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update airflow tests for PyTorch/XLA 2.5 release #380

Merged
merged 19 commits into from
Sep 13, 2024

Conversation

ManfeiBai
Copy link
Collaborator

@ManfeiBai ManfeiBai commented Sep 9, 2024

Description

Adding tests for PyTorch/XLA 2.5 release and removing 2.4 release tests.

Tests

Please describe the tests that you ran on Cloud VM to verify changes.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run one-shot tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

@zpcore
Copy link
Collaborator

zpcore commented Sep 9, 2024

Thanks, we need to update dags/legacy_test/tests/pytorch/r2.4/common.libsonnet also to point to 2.5 test.

@ManfeiBai ManfeiBai changed the title Update airflow tests for PyTorch/XLA 2.5 release [Do Not Merged] Update airflow tests for PyTorch/XLA 2.5 release Sep 9, 2024
@ManfeiBai
Copy link
Collaborator Author

cc @bhavya01, @tengyifei

@ManfeiBai
Copy link
Collaborator Author

ManfeiBai commented Sep 9, 2024

Due to PyTorch has not tag for 2.5 yet, will update and test local for checklist and attach graph for 2.5 after PyTorch has 2.5 tag

PyTorch has v2.5.0-rc1 tag now, pytorch/xla#7978 has merged, and tag has been pushed too, will wait for built wheel and docker to run local one-shot test, then merge this PR for nightly tests

@ManfeiBai ManfeiBai changed the title [Do Not Merged] Update airflow tests for PyTorch/XLA 2.5 release Update airflow tests for PyTorch/XLA 2.5 release Sep 13, 2024
Copy link
Collaborator

@zpcore zpcore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ManfeiBai ManfeiBai merged commit f3201ec into GoogleCloudPlatform:master Sep 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants