trap SIGINT to suppress noisy stack traces #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mservidio
previously approved these changes
Mar 7, 2023
t8dogg
reviewed
Mar 7, 2023
t8dogg
approved these changes
Mar 7, 2023
Co-authored-by: Matt Tait <[email protected]>
t8dogg
approved these changes
Mar 7, 2023
|
@salsferrazza needs some linting clean up, I touched up a couple of the issues |
mservidio
dismissed
their stale review
Let's review the signal wire up with global keyword
mservidio
requested changes
Mar 10, 2023
|
One other thought, the logic in main.py will only be a feature add for cli usage, but not library usage. Moving this into the MessageParser instance may be more beneficial. |
mservidio
changed the title
mservidio
changed the title
|
@salsferrazza re-factored a little, take a look... |
mservidio
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Control-C'ing out of a transcoder process run in the foreground exits with a very noisy stack trace that inhibits immediate diagnostics of the last few messages. This CL traps SIGINT and exists more gracefully. It also provides the basic entry point for #13 and #111.