Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify contributing readme #609

Merged
merged 3 commits into from
May 17, 2023
Merged

Clarify contributing readme #609

merged 3 commits into from
May 17, 2023

Conversation

bourgeoisor
Copy link
Member

@bourgeoisor bourgeoisor commented May 17, 2023 •
edited
Loading

This PR helps clarify the contributing README by removing potential ambiguity / tweak word choices.

Staged: https://github.com/GoogleCloudPlatform/kubernetes-engine-samples/blob/issue-clarify-contributing-readme/.github/CONTRIBUTING.md

@bourgeoisor bourgeoisor requested a review from a team as a code owner May 17, 2023 18:18
NimJay
NimJay approved these changes May 17, 2023
View reviewed changes
Copy link
Collaborator

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you just want approval from Leonid, but I also just approved.

Thanks for adding clarity to these instructions. Looks good.
Feel free to ignore my suggestions about replacing "PR" with "pull-request".

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
@bourgeoisor bourgeoisor merged commit 1915a1d into main May 17, 2023
@bourgeoisor bourgeoisor deleted the issue-clarify-contributing-readme branch May 17, 2023 21:34
@bourgeoisor
Copy link
Member Author

I created #611 for the automation bits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NimJay NimJay NimJay approved these changes

@minherz minherz minherz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bourgeoisor @minherz @NimJay