feat: add support for GOOGLE_CLOUD_UNIVERSE_DOMAIN env var
#1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackwotherspoon
commented
Jan 10, 2025
| if universe_domain: | ||
| self._universe_domain = universe_domain | ||
| else: | ||
| self._universe_domain = os.environ.get("GOOGLE_CLOUD_UNIVERSE_DOMAIN") # type: ignore |
There was a problem hiding this comment.
need to have # type: ignore here as os.environ.get has weird type hinting
was causing mypy check to complain during lint:
google/cloud/sql/connector/connector.py:179: error: Incompatible types in assignment (expression has type "Optional[str]", variable has type "str") [assignment]
hessjcg
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
universe_domainto be set via theGOOGLE_CLOUD_UNIVERSE_DOMAINenv var.This will allow zero code changes to support non-GDU environments, instead users can set the env var.
Order of operations for setting universe domain will be as follows:
universe_domainargument passed toConnector()GOOGLE_CLOUD_UNIVERSE_DOMAINenv var"googleapis.com"Fixes #1217