Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use black isort profile and update to latest #1211

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

jackwotherspoon
Copy link
Collaborator

We use both isort and black formatter's as part of our lint job.

isort has preset profiles, we were using google previously but it has begun to
cause conflicts with the black formatter, leading to lint job failures.

Instead, we can use the black profile for isort and then manually toggle the other
flags to match the google profile.

@jackwotherspoon jackwotherspoon merged commit 5af7582 into main Dec 9, 2024
15 checks passed
@jackwotherspoon jackwotherspoon deleted the black-isort branch December 9, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants