Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set PSC ip type based on pscEnabled #1158

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Conversation

jackwotherspoon
Copy link
Collaborator

@jackwotherspoon jackwotherspoon commented Sep 10, 2024

With CAS-based instances being supported soon and also using dnsName,
we can no longer rely on the presence of dnsName in the connectSettings
API as identifying that PSC is enabled on an instance.

Instead we should check pscEnabled from the response as source of truth.

Check if pscEnabled is True before setting PSC ip type.

@jackwotherspoon jackwotherspoon self-assigned this Sep 10, 2024
@jackwotherspoon jackwotherspoon requested a review from a team as a code owner September 10, 2024 20:43
@jackwotherspoon jackwotherspoon changed the title fix: only set PSC ip type if PSC is enabled fix: set PSC ip type based on pscEnabled Sep 10, 2024
@jackwotherspoon
Copy link
Collaborator Author

jackwotherspoon commented Sep 10, 2024

Need to add pscEnabled to unit test mock API response.

Copy link
Member

@enocom enocom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Definitely want to add a test for this somewhere.

@jackwotherspoon jackwotherspoon merged commit 53e40c7 into main Sep 12, 2024
15 checks passed
@jackwotherspoon jackwotherspoon deleted the psc-enabled-check branch September 12, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants