Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add Cobra docs generator and CI to ensure they remain up to date #2336
docs: Add Cobra docs generator and CI to ensure they remain up to date #2336
Changes from 2 commits
a7aad29
b20fd7e
93f3222
dd4b578
5829a5d
d26f22e
24ea4ee
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's cleaner to check for valid input first and then proceed with usual operations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good 😉 Applied
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have created a similar change as this PR for AlloyDB: GoogleCloudPlatform/alloydb-auth-proxy#730.
I was getting govulncheck error when using the
genutils
library here: https://github.com/GoogleCloudPlatform/alloydb-auth-proxy/actions/runs/12130089556/job/33819727861.I think we can change this to
outDir, err := filepath.Abs(path)
instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, I saw it has some extra checks, but I think it is not worth it. One less dependency 😄
Large diffs are not rendered by default.