deps: bundlesize to 0.18.0 #10272
Merged
deps: bundlesize to 0.18.0 #10272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
approved these changes
Jan 28, 2020
|
didn't fix anything. fwiw i also tried refreshing the env variable on travis but no luck either. |
|
The upstream bug: siddharthkp/bundlesize#308 |
|
Brendan points me to #9089 where he called out out bundlewatch (which looks nice) and speaking of other options.. there's also |
|
I'm also looking for alternative solutions. The aforementioned issue is present for so many months. Also, bundlesize itself is quite a big devDependency and requires native bindings due to brotli. One could just target Node.js > 10.16 or so that has brotli built in. I'll keep an eye on bundlewatch. I've also found https://github.com/ampproject/filesize but it doesn't seem to integrate with pull requests. |
ctavan
added a commit
to uuidjs/uuid
that referenced
this pull request
Feb 7, 2020
Bundlesize is unmaintained and currently doesn't support reporting differences compared to master, see: siddharthkp/bundlesize#308 As mentioned here, Bundlewatch seems to be a working successor: GoogleChrome/lighthouse#10272 (comment)
ctavan
added a commit
to uuidjs/uuid
that referenced
this pull request
Feb 10, 2020
Bundlesize is unmaintained and currently doesn't support reporting differences compared to master, see: siddharthkp/bundlesize#308 As mentioned here, Bundlewatch seems to be a working successor: GoogleChrome/lighthouse#10272 (comment)
ctavan
added a commit
to uuidjs/uuid
that referenced
this pull request
Feb 10, 2020
Bundlesize is unmaintained and currently doesn't support reporting differences compared to master, see: siddharthkp/bundlesize#308 As mentioned here, Bundlewatch seems to be a working successor: GoogleChrome/lighthouse#10272 (comment)
ctavan
added a commit
to uuidjs/uuid
that referenced
this pull request
Feb 10, 2020
Bundlesize is unmaintained and currently doesn't support reporting differences compared to master, see: siddharthkp/bundlesize#308 As mentioned here, Bundlewatch seems to be a working successor: GoogleChrome/lighthouse#10272 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hopefully fixing the spam in our CI output.