This repository has been archived by the owner on Mar 14, 2024. It is now read-only.
Allow custom <video> aspect ratio #3295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure how to interpret the lighthouse failure here. |
bramus
reviewed
Aug 4, 2022
| @@ -23,5 +23,9 @@ main:focus { | |||
| } | |||
|
|
|||
| video { | |||
| // These custom properties are set by the Video shortcode if both the width | |||
| // and height attributes are set. | |||
| aspect-ratio: var(--vid-width) / var(--vid-height); | |||
There was a problem hiding this comment.
What if these attributes are not set? Should be add fallback values or simply allow this value to become invalid?
There was a problem hiding this comment.
The fallback would be the default object size of 300x150 right?
There was a problem hiding this comment.
Falling back to invalid, which is a no-op, is probably more compatible with existing content on the site.
|
I haven't tested this btw, so it'll need an eyeball to check that it works with existing video content. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of GoogleChrome/webdev-infra#28, to allow custom aspect ratio on
<video>and reduce CLS.