Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Summarizer sample: Format markdown output #1283

Merged
merged 5 commits into from
Nov 9, 2024
Merged

Summarizer sample: Format markdown output #1283

merged 5 commits into from
Nov 9, 2024

Conversation

sebastianbenz
Copy link
Collaborator

Also call the API in the same way as the official sample.

@sebastianbenz sebastianbenz changed the title Format markdown output Summarizer sample: Format markdown output Sep 13, 2024
oliverdunk
oliverdunk approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@oliverdunk oliverdunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks good to me! Love the use of dompurify.

functional-samples/ai.gemini-on-device-summarization/sidepanel/index.js Outdated Show resolved Hide resolved
@sebastianbenz
Styles and config
bae0dde 
* Some CSS love with open props
* Make summary configurable
@sebastianbenz
Copy link
Collaborator Author

New look:

Screenshot 2024-11-08 at 21 18 39

@oliverdunk PTAL
@tomayac PTAL

@sebastianbenz sebastianbenz requested a review from tomayac November 8, 2024 20:19
tomayac
tomayac approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@tomayac tomayac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two mega nits.

functional-samples/ai.gemini-on-device-summarization/sidepanel/index.js Outdated Show resolved Hide resolved
functional-samples/ai.gemini-on-device-summarization/manifest.json Outdated Show resolved Hide resolved
sebastianbenz and others added 2 commits November 8, 2024 22:52
@sebastianbenz
Copy link
Collaborator Author

Thanks Tom!

@sebastianbenz sebastianbenz merged commit fc7c4b3 into main Nov 9, 2024
7 checks passed
@sebastianbenz sebastianbenz deleted the ai-summary2 branch November 9, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverdunk oliverdunk oliverdunk approved these changes

@tomayac tomayac tomayac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebastianbenz @tomayac @oliverdunk