Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add settings import/export to fontSettings #1037

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

patrickkettner
Copy link
Collaborator

The advanced font settings is the repo for Advanced Font Settings repo. A developer reached out to request this functionality, so I am updating the sample for approval before publishing it.

Copy link
Member

@oliverdunk oliverdunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments but otherwise this seems reasonable, thanks for working on it :)

api-samples/fontSettings/fontSettings Advanced/options.js Outdated Show resolved Hide resolved
api-samples/fontSettings/fontSettings Advanced/options.js Outdated Show resolved Hide resolved
@patrickkettner
Copy link
Collaborator Author

@oliverdunk should be ready for a rereview

Copy link
Member

@oliverdunk oliverdunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't had a chance to test unfortunately but otherwise LGTM.

@patrickkettner patrickkettner merged commit dcd08ad into main Nov 30, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants