add realtime superfluid donations amounts to donor profiles #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…time-donation-flow
krisbitney
changed the title
…time-donation-flow
…time-donation-flow
krisbitney
changed the title
…me-donation-flow # Conflicts: # packages/app/src/components/CollectiveCard/DonorCollectiveCard.tsx # packages/app/src/components/CollectiveCard/StewardCollectiveCard.tsx # packages/app/src/components/DonorsList/DonorsListItem.tsx # packages/app/src/components/ViewCollective.tsx # packages/app/src/models/constants.ts
…me-donation-flow # Conflicts: # packages/app/src/components/DonorsList/DonorsListItem.tsx
…ists Desktop ViewStewardsPage and ViewDonorsPage UI
sirpy
requested changes
Jan 2, 2024
| const decimalCurrentPool = parseFloat(ethers.utils.formatEther(currentPool ?? 0)); | ||
| const formattedCurrentPool: string = decimalCurrentPool.toFixed(3); | ||
| const currentPoolUsdValue = tokenPrice ? tokenPrice * decimalCurrentPool : undefined; | ||
| const { formatted: formattedDonations, usdValue: donationsUsdValue } = calculateAmounts(totalDonations, tokenPrice); |
There was a problem hiding this comment.
donation to pools should use flow rate
There was a problem hiding this comment.
only stewards currently receive single payments.
donor can donate a single donation or a flow therefor pools have incoming flow rate on top of single donations
There was a problem hiding this comment.
I fixed this in a new commit. Please take a look when you have a chance.
sirpy
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds realtime donation amounts to wallet profiles, and also adds improvements to ViewDonorsPage and ViewStewardsPage