fixed padding on ViewCollective mobile page; fixes for Stewards list #49
Conversation
…-padding # Conflicts: # packages/app/src/pages/ViewCollectivePage.tsx
krisbitney
changed the title
| @@ -60,27 +56,27 @@ function ViewCollective({ | |||
| const [isDesktopResolution] = useMediaQuery({ | |||
| minWidth: 612, | |||
| }); | |||
| // TODO: need actual token price | |||
There was a problem hiding this comment.
can be used for getting the g$ price
Example usage here: https://github.com/GoodDollar/GoodProtocolUI/blob/29604cf6290e7489e040643444e145d860c5c6bf/src/pages/gd/Claim/ClaimBalance.tsx#L23
also found this local hook which alternatively can be used:
https://github.com/GoodDollar/GoodCollective/blob/a9ef6a95193baa28110cc18ca81336cde59d7df8/packages/app/src/hooks/useGetTokenPrice.tsx
There was a problem hiding this comment.
yes, this has already been resolved
| @@ -143,7 +139,7 @@ function ViewCollective({ | |||
| console.log(stopDonationModal); | |||
| }} | |||
| /> | |||
| {renderDonorsButton} | |||
| {renderDonorsButton()} | |||
There was a problem hiding this comment.
Better make it its own component
There was a problem hiding this comment.
This is out of scope
| rowInfo="Total Paid Out" | ||
| rowData={totalPaidOut ?? 0} | ||
| currency="G$" | ||
| balance={tokenPrice * (totalPaidOut ?? 0)} |
There was a problem hiding this comment.
calculations better outside of render
| /> | ||
| <RowItem imageUrl={GreenListIcon} rowInfo="# of Payments Made" rowData={paymentsMade ?? 0} currency="" /> |
There was a problem hiding this comment.
Even though I think this whole component could be dry'ed up
at least these row-items could be done with a map, and storing the props in a object. same goes for the links
There was a problem hiding this comment.
This is out of scope
Closes #32
Closes #33
Closes #35
Closes #36
Closes #38