fix: map fullnames to addresses correctly #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sirpy
requested changes
Feb 4, 2024
| variables: { query: { index: { walletAddress: { hash_in: hashedAddresses } } } }, | ||
| variables: { | ||
| query: { | ||
| fullName: { privacy: 'public' }, |
There was a problem hiding this comment.
not required.
if not public display will be empty
| walletAddress: { | ||
| hash: string; | ||
| display?: string; | ||
| value?: string; |
There was a problem hiding this comment.
also seems like we are not using UserProfile interface anywhere. so either remove it or use it
There was a problem hiding this comment.
UserProfile interface is used in the UserProfilesResponse interface
sirpy
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We fetched full-names but they were not mapped back to the addresses.
About # (link your issue here)
#140
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: