Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wide layout + more #119

Merged
merged 6 commits into from
Jan 28, 2024
Merged

fix wide layout + more #119

merged 6 commits into from
Jan 28, 2024

Conversation

krisbitney
Copy link
Contributor

@krisbitney krisbitney commented Jan 25, 2024

This PR fixes

  • the layout for horizontal resolutions greater than 1280 pixels
  • the position of the See all stewards button on the desktop ViewCollective page
  • the width of the SEE YOUR IMPACT button on desktop
  • replaces overflow: 'scroll' with overflow: 'auto'

@L03TJ3
Copy link
Collaborator

L03TJ3 commented Jan 26, 2024

@krisbitney sorry m8, should have mentioned this earlier
the more complete fix would be to use Platform.select and set the style property for web/android separately

@krisbitney
Copy link
Contributor Author

@krisbitney sorry m8, should have mentioned this earlier the more complete fix would be to use Platform.select and set the style property for web/android separately

That's fantastic. Thank you. I made the change.

@L03TJ3 L03TJ3 merged commit 559ff7c into master Jan 28, 2024
2 checks passed
@L03TJ3 L03TJ3 deleted the kris/qa-fixes branch January 28, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants