Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch full names of users #113

Merged
merged 298 commits into from
Jan 21, 2024
Merged

fetch full names of users #113

merged 298 commits into from
Jan 21, 2024

Conversation

krisbitney
Copy link
Contributor

Adds support for fetching users' full names from GoodDollar's mongodb database

@krisbitney krisbitney requested review from L03TJ3 and sirpy January 15, 2024 07:32
@krisbitney
Copy link
Contributor Author

@sirpy @L03TJ3 I don't have a way to test whether the fetch from mongodb is working. Could you please assign a full name to a supporter or steward's address in your database and tell me the address?

You can use my address if you'd like: 0xC3C54Ee8B495A5004602AFf40c5880fb8E375aaD.

@L03TJ3
Copy link
Collaborator

L03TJ3 commented Jan 15, 2024

@sirpy

  1. from localhost this does not work as origin is blocked by realm
  2. is it even possible to add these type of domains: https://good-collective-h7tf69zke-gooddollarteam.vercel.app/ to accepted origin list? (the deployment link is updated every push to web3Integrations branch)

steward verification, current pool, # people supported
@krisbitney
Copy link
Contributor Author

I just remembered that I forgot to add caching. I will add that tomorrow.

krisbitney and others added 2 commits January 16, 2024 11:20
* fix social links and show only if available

* changed DonorListItem amount display from toFixed to toString

* sort connectors with WalletConnect before MetaMask

* added token symbol next to wallet balance and adjusted balance formatting

* update copy for on-time donation, added chain check to useEthersSigner and useGetTokenBalance

* one-time transfer now assumes token is already approved for transfer

* G$ donation now assumes token is already approved for transfer

* added infoButton property to ipfs meta data in subgraph

* increased slippage tolerance from 0.5% to 1%

* made it so only G$ shows in token list for one-time donations

* made it so selecting one-time donation changes currency to G$ and amount to 0

* fixed total donation usd value

* swap errors will only show if donation amount is not zero

* added infoLabel to front end

* updated breadcrumb to show collective name and only go back to previous page if back arrow is clicked

* updated breadcrumb to fix links and text

* incremented subgraph starting block because prior block was failing

* donation is now disabled if swap required and token approval not yet ready; token approval should not fail on retry

* breadcrumb formatting for '/'

* adjusted G$ formatting in profile

* modal and donation error formatting

* added steward profile link to steward list item

* added polling to donor in wallet; improved error message in donation functions

* fix for error message in donation functions

* switched from supportSingleTransferAndCall to supportSingleBatch since it includes token approval

* removed warnings for missing subgraph items

* set margin between collective cards on home page to 24

* fixed transaction list UI

* added useRecentTransactions hook

* fixed ViewCollective tablet portrait resolution

* removed G$ fractional amount from connected wallet display, and added currency symbol to mobile version

* made sure G$ displayed amount is rounded down to nearest int

* fixed stop donation

* changed default gas price to 5 in @gooddollar/goodcollective-sdk

* renamed enum value from celo to CELO

* currentPool is now a flowing balance

* refactor: dry up donate button styles, no inline arrow functions

* fix: getDonateStyles, does not stop loop after hitting first true

* fix: simplify getDonateStyles

* inline lambdas to const

* memoized onChangeFrequency

* fixed link to smart contract in ViewCollective

* version bump

* version bump

* version bump

* version bump

* version bump

* version bump

* version bump

* version bump

* version bump

* chore: release sdk, bump in app

---------

Co-authored-by: LewisB <[email protected]>
Base automatically changed from kris/bug-fixes to web3Integrations January 16, 2024 08:29
Copy link
Contributor

@sirpy sirpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created here a full example of how to use mongodb with graphql.
it also includes caching policies package.
and a modified fetch query to fetch all profiles at once instead of doing multiple queries.
https://github.com/sirpy/realm-graphql-apollo-react
index.js - shows how client and cache are initialized
graphql-operations.js - includes the graphql query
app.js - the fetch query itself

create a separate graphql client for profile queries

…-names

# Conflicts:
#	packages/app/src/components/StewardsList/StewardsListItem.tsx
#	packages/app/src/components/TransactionList/TransactionList.tsx
#	packages/app/src/components/TransactionList/TransactionListItem.tsx
#	packages/app/src/components/ViewCollective.tsx
#	packages/app/src/pages/WalletProfilePage.tsx
Base automatically changed from web3Integrations to master January 18, 2024 01:18
@krisbitney
Copy link
Contributor Author

krisbitney commented Jan 18, 2024

@sirpy I am getting the following error. Is this the issue of needing to whitelist a URL? The same as before?

Screenshot 2024-01-18 at 1 57 12 PM

This is happening in the deployment preview, so it doesn't seem to be a CORS issue.

https://good-collective-2cu9o7u9x-gooddollarteam.vercel.app/collective/0x11f18e8f2a27d54a605cf10486b3d4c5aeeba81f/donors

# Conflicts:
#	packages/app/src/App.tsx
#	packages/app/src/components/TransactionList/TransactionList.tsx
#	packages/app/src/components/TransactionList/TransactionListItem.tsx
#	packages/app/src/hooks/useRecentTransactions.ts
@L03TJ3 L03TJ3 merged commit 2ee9dbe into master Jan 21, 2024
2 checks passed
@L03TJ3 L03TJ3 deleted the kris/full-names branch October 15, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants