Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX/UI]: Transactions list show more #124

Closed
2 tasks
L03TJ3 opened this issue Jan 30, 2024 · 21 comments
Closed
2 tasks

[UX/UI]: Transactions list show more #124

L03TJ3 opened this issue Jan 30, 2024 · 21 comments
Assignees
Labels
bug Something isn't working P1 - High Important issues that should be resolved soon. 🙊 stale

Comments

@L03TJ3
Copy link
Collaborator

L03TJ3 commented Jan 30, 2024

How to handle show more button on the transactions list

  • look into lazy loading the transactions
  • should it expand the list?
@L03TJ3 L03TJ3 self-assigned this Jan 31, 2024
@patpedrosa patpedrosa added the P1 - High Important issues that should be resolved soon. label Jan 31, 2024
@decentralauren
Copy link

@L03TJ3 is this an open item that needs to be assigned to Kris?

@L03TJ3
Copy link
Collaborator Author

L03TJ3 commented Feb 1, 2024

@decentralauren not sure. is this in scope? then yes, else no it will stay assigned to me I guess

@decentralauren
Copy link

@krisbitney I've added you to build both the "show more" functionality in web and the lazy load in mobile. We are open to adding a "show more" to both and redirecting to the appropriate page in the explorer.

@krisbitney
Copy link
Contributor

@krisbitney I've added you to build both the "show more" functionality in web and the lazy load in mobile. We are open to adding a "show more" to both and redirecting to the appropriate page in the explorer.

I'm not available to add more features beyond the original requirements. I noticed those seem to have been removed from the notion today, or at least my ability to view them.

@decentralauren
Copy link

Hi @krisbitney - I don't know what notion you're referring to. We're updating the requirements to make them easier for you to implement. The original requirement which was shared in FIgma was for the transactions to load 5 at a time and then lazy load upon scroll. Here is a link to the comment.

@krisbitney
Copy link
Contributor

I'm referring to the original requirements that were shared with us: https://serota.notion.site/GoodCollective-dApp-MVP-RFP-ba06e28f43e24b85aa336ad7f983c69f

@decentralauren
Copy link

@krisbitney we were clear with the team that the majority of requirements were documented as comments in the Figma with "Devs." We also walked through these with the team in detail, and you'll notice these comments were there from 7 months ago. I'm sorry that this wasn't handed over to you and explains some of the confusion with how things were implemented.

@decentralauren
Copy link

We only used the notion to document non-functional requirements or requirements not directly related to the UI. This is why the notion does not include requirements for much of the UI-related flows.

@krisbitney
Copy link
Contributor

@krisbitney we were clear with the team that the majority of requirements were documented as comments in the Figma with "Devs." We also walked through these with the team in detail, and you'll notice these comments were there from 7 months ago. I'm sorry that this wasn't handed over to you and explains some of the confusion with how things were implemented.

Hmm. Okay. Let me talk to dOrg people and see if I can get a better understanding.

@krisbitney
Copy link
Contributor

krisbitney commented Feb 5, 2024

@krisbitney I've added you to build both the "show more" functionality in web and the lazy load in mobile. We are open to adding a "show more" to both and redirecting to the appropriate page in the explorer.

After speaking with others, it is my understanding that the Figma was not available at the time the project was scoped and the SoW was signed.

Still, if you're asking for an easier solution than lazy loading (which is easy on mobile but harder on web), then I am happy to do implement it. Could you clarify what you would like the "show more" button to do?

@krisbitney
Copy link
Contributor

krisbitney commented Feb 5, 2024

I think I misunderstood what you were asking for before

@krisbitney
Copy link
Contributor

@decentralauren I think this is what you were asking for? #168

@patpedrosa
Copy link

This is what I see when I click on Show more:
Screen Shot 2024-02-05 at 15 04 33

@vldkhh vldkhh added the bug Something isn't working label Feb 5, 2024
@vldkhh
Copy link

vldkhh commented Feb 5, 2024

@L03TJ3 @patpedrosa @decentralauren rejected, put it in Sprint

@krisbitney
Copy link
Contributor

@L03TJ3 @patpedrosa @decentralauren rejected, put it in Sprint

Here is a fix for it. Sorry, it was late last night and I didn't check to make sure it worked because it's a simple change.

#170

It will work with this PR.

@L03TJ3
Copy link
Collaborator Author

L03TJ3 commented Feb 6, 2024

Needs to be done the same way on mobile, that still shows the see all transactions buttons. @krisbitney

@krisbitney
Copy link
Contributor

Fixed here: #176

@L03TJ3
Copy link
Collaborator Author

L03TJ3 commented Feb 8, 2024

@vldkhh after qa this one is for product review to determine the initial request of loading more transactions on the page

@decentralauren
Copy link

@vldkhh has this passed QA?

@vldkhh
Copy link

vldkhh commented Feb 14, 2024

@decentralauren from my perspective - yes

Copy link

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1 - High Important issues that should be resolved soon. 🙊 stale
Projects
None yet
Development

No branches or pull requests

5 participants