Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] recent transactions doesnt enable to see tx #143

Closed
sirpy opened this issue Feb 1, 2024 · 9 comments
Closed

[Bug] recent transactions doesnt enable to see tx #143

sirpy opened this issue Feb 1, 2024 · 9 comments
Assignees

Comments

@sirpy
Copy link
Contributor

sirpy commented Feb 1, 2024

The tx hash is incomplete. copying the tx hash should copy the whole tx or it should link to the explorer
show more also doesnt work correctly but i've seen there's a ticket about it, so not sure if its a bug.

@sirpy
Copy link
Contributor Author

sirpy commented Feb 1, 2024

@patpedrosa @decentralauren FYI, please assign.

@krisbitney
Copy link
Contributor

Worth considering: making the tx hash complete would cause it to spill over to the next line. That choice requires additional design considerations.

@L03TJ3
Copy link
Collaborator

L03TJ3 commented Feb 1, 2024

show more button issue is defined here: #124

@L03TJ3
Copy link
Collaborator

L03TJ3 commented Feb 1, 2024

@decentralauren @patpedrosa
should we just apply the same what we did for wallet feed?
truncated (first x / last x) and make the tx hash link to the explorer?

@decentralauren
Copy link

@L03TJ3 the transaction item should link to the explorer.

Not sure what you mean by "truncated (first x / last x)"?

@krisbitney
Copy link
Contributor

@L03TJ3 the transaction item should link to the explorer.

Not sure what you mean by "truncated (first x / last x)"?

He means "0x12345...12345" format

@krisbitney krisbitney assigned krisbitney and unassigned krisbitney Feb 1, 2024
@krisbitney
Copy link
Contributor

Fixed in this PR: #151

@L03TJ3
Copy link
Collaborator

L03TJ3 commented Feb 1, 2024

@vldkhh moved to qa

@vldkhh
Copy link

vldkhh commented Feb 5, 2024

verified. it opens the explorer with the following info by clicking on tx hash

@vldkhh vldkhh closed this as completed Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants