Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DM] adding Batch Import plugin to repo. #860

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Conversation

dejanmarkovic
Copy link
Contributor

Summary

Issues

  • no known issues

Testing Instructions

Please test with test CSV files first

Screenshots

Copy link
Contributor

@jaspercroome jaspercroome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a downloadable csv template file to the page? A simple 1-row csv with a relevant header for each column would be super helpful.

@dejanmarkovic
Copy link
Contributor Author

Could you add a downloadable csv template file to the page? A simple 1-row csv with a relevant header for each column would be super helpful.

I can add it to the GUI below the submit button. The other way would be to upload the test file to the discourse thread https://goodbids.discourse.group/t/enhancement-batch-processing-on-the-front-end/532/111. Please let me know which way would you prefer. Thanks, Dejan

2. Added example .csv file
3. Added plugin path to gitignore
@jaspercroome
Copy link
Contributor

Thanks, Dejan - could you add it to the GUI below the submit button? That'll make it most discoverable.

Re: local network admin access - if you navigate to the root directory and run bin/start, you'll run a command that gives you local network-admin credentials.
Screenshot 2024-04-03 at 2 46 04 PM

@dejanmarkovic
Copy link
Contributor Author

Thanks, Dejan - could you add it to the GUI below the submit button? That'll make it most discoverable.

Re: local network admin access - if you navigate to the root directory and run bin/start, you'll run a command that gives you local network-admin credentials. Screenshot 2024-04-03 at 2 46 04 PM

Hi Jasper,

//- could you add it to the GUI below the submit button?
I have already added that to the GUI in my commit [9a6663c].

// if you navigate to the root directory and run bin/start
In the example above 'bin/start' looks like something that has to be done in the command line with SSH (I don't have those credentials).
Can you please advise?

@jaspercroome
Copy link
Contributor

If you're working on this locally, you should be able to navigate to the root directory in your cli tool of choice and run bin/start. If that's not working, Do you have Docker installed?

@dejanmarkovic
Copy link
Contributor Author

bin/start

Hi Jasper,

I've got the right permissions on the dev environment https://goodbids-develop.go-vip.net/.
The problem was that the system had downgraded my account until I enabled the 2-factor authentication.
Can you please approve my PR when you get a chance so I can test the plugin there?
Thanks,
Dejan

Copy link
Contributor

@jaspercroome jaspercroome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, works locally. Thanks, Dejan!

@dejanmarkovic dejanmarkovic merged commit 13bc9c8 into main Apr 3, 2024
1 check passed
@dejanmarkovic dejanmarkovic deleted the dm/dm-batch-import branch April 3, 2024 23:27
@dejanmarkovic
Copy link
Contributor Author

Hi Jasper, I have tested it on the dev and everything looks OK.

In order to test that I used my emails which I have now removed and did another commit. No emails $toEmail = '[email protected]'; $ccEmail = '[email protected]'; are active.

I don't see that commit '668c55e18d85891492e66e71169fb53c8ab90b66' in this thread (it should be here as it's the same branch).
Can you please approve it when you get a chance so it can be deployed to dev?

It's 2:10 am here so I am going to sleep and I will be able to test it again when I get up.

Thank you so much for the help and we will chat tomorrow.
Dejan

@jaspercroome
Copy link
Contributor

jaspercroome commented Apr 4, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants