-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DM] adding Batch Import plugin to repo. #860
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a downloadable csv template file to the page? A simple 1-row csv with a relevant header for each column would be super helpful.
I can add it to the GUI below the submit button. The other way would be to upload the test file to the discourse thread https://goodbids.discourse.group/t/enhancement-batch-processing-on-the-front-end/532/111. Please let me know which way would you prefer. Thanks, Dejan |
2. Added example .csv file 3. Added plugin path to gitignore
Hi Jasper, //- could you add it to the GUI below the submit button? // if you navigate to the root directory and run bin/start |
If you're working on this locally, you should be able to navigate to the root directory in your cli tool of choice and run |
Hi Jasper, I've got the right permissions on the dev environment https://goodbids-develop.go-vip.net/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, works locally. Thanks, Dejan!
Hi Jasper, I have tested it on the dev and everything looks OK. In order to test that I used my emails which I have now removed and did another commit. No emails $toEmail = '[email protected]'; $ccEmail = '[email protected]'; are active. I don't see that commit '668c55e18d85891492e66e71169fb53c8ab90b66' in this thread (it should be here as it's the same branch). It's 2:10 am here so I am going to sleep and I will be able to test it again when I get up. Thank you so much for the help and we will chat tomorrow. |
Thanks, Dejan! I've created a release for staging with this work, so you should be able to test on staging tomorrow when you are ready.
Hope you recharge & rest up! Thanks for all your contributions this week.
Jasper
…On Wednesday, April 3rd, 2024 at 5:12 PM, Dejan Markovic ***@***.***> wrote:
Hi Jasper, I have tested it on the dev and everything looks OK.
In order to test that I used my emails which I have now removed and did another commit. No emails $toEmail = ***@***.***'; $ccEmail = ***@***.***'; are active.
I don't see that commit '668c55e18d85891492e66e71169fb53c8ab90b66' in this thread (it should be here as it's the same branch).
Can you please approve it when you get a chance so it can be deployed to dev?
It's 2:10 am here so I am going to sleep and I will be able to test it again when I get up.
Thank you so much for the help and we will chat tomorrow.
Dejan
—
Reply to this email directly, [view it on GitHub](#860 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/A6RAIYCHBJQD3U2G5FGVOOTY3SLIRAVCNFSM6AAAAABFVIZXAOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZVHAZTMNRUHA).
You are receiving this because you were assigned.Message ID: ***@***.***>
|
Summary
Issues
Testing Instructions
Please test with test CSV files first
Screenshots