Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: first time dialog #852

Merged
merged 3 commits into from
Apr 1, 2024
Merged

feat: first time dialog #852

merged 3 commits into from
Apr 1, 2024

Conversation

jaspercroome
Copy link
Contributor

Summary

When a user arrives at an auction on GOODBIDS for the first time, we should remind them how positive auctions work. This one-time dialog will pop up, require confirmation from the user, and then set a cookie once confirmed successfully so that it does not render again (or until a user uses a different browser)

Notes

This should be replaced long-term with a user data field, so that it exists in perpetuity.

@jaspercroome jaspercroome merged commit e28132a into main Apr 1, 2024
1 check passed
@jaspercroome jaspercroome deleted the jc/add-first-time-dialog branch April 1, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant