[#495] Setting up a default Navigation #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All in the same hook where the pages get created, trying to figure out a different place to do it. |
|
Is this still a draft? |
|
Yep it is still a draft. Once we get the hook added for creating site we will update this PR so the nav get created on that hook. |
|
@nathan-schmidt-viget This should be good to go. Give this a test and let me know if it's working. The Navigation will be updated when the Site is verified (not initialized, that hook is too early). |
nathan-schmidt-viget
force-pushed
the
ns/495-init-nav
branch
from
f649de9 to
08fab0b
Compare
* [#495] Setting up basic test with nav links * [#495] testing out pattern for custom menu * [#495] pulling in the created pages into the new nav * [#495] adding notes for TODO * [#495] getting active nav post id * [#495] A couple of tweaks, potential bug fixes * [#495] Some fixes/adjustments * [#495] Used Verified hook for Navigation Changes * [#495] Fix nav + other bug fixes --------- Co-authored-by: Nathan Schmidt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The option to render inner blocks inside of core/navigation will be in WP version 6.5. So this is a workaround for now. See the notes in the ticket for more details #495.
This updates the
wp_navigationcontent with the two About and Auctions page using<!-- wp:navigation-link -->. This allows us (and the user) to have full control of the navigation block in Gutenberg.Things still TODO:
Figure out how to get nav ID - it is always the first one.Issues
Testing Instructions
Screenshots
Front-end
Admin