Plugin Stuff #50
Plugin Stuff #50
Conversation
| # Loaded via Composer | ||
| /plugins/advanced-custom-fields-pro/ | ||
| /plugins/cookie-law-info/ | ||
| /plugins/pojo-accessibility/ |
There was a problem hiding this comment.
Is this plugin necessary? Our general stance is to not use accessibility toolbars.
There was a problem hiding this comment.
Couple thoughts here:
- GB requested an a11y overlay tool, but I think it's still an open discuss about what that will be. @bd-viget let me know if we have a strong preference for this one (I don't remember this being on our list, I'll check in Notion)
- The GDPR consent plugin decision is still open as well, although I thought we were leaning toward OneTrust (WPVIP's recommendation). Happy to pivot if this your preference though @bd-viget
There was a problem hiding this comment.
The accessibility plugin is the one I thought was in our GB requirements. I don't have any other suggestions on alternatives.
I just picked the most popular GDPR plugin, but if we need to use another one, I'm totally fine, not sold on any specific one.
There was a problem hiding this comment.
@clatwell @bd-viget I think it's worth digging into the why on the a11y plugin. @nathan-schmidt-viget wrote an article about why these are not just benign but harmful for accessibility. I'd guess that they "just want to cover accessibility" but don't know that we'll build an accessible site that won't need this plugin.
There was a problem hiding this comment.
@bd-viget - Oh, you're right, I didn't realize that "pojo accessibility" was the One Click Accessibility plugin they recommended. @nathan-schmidt-viget had a recommendation for an alternative that shows errors directly on the page. See this comment.
@ten1seven - GB is a multi-site network in which individual Nonprofits will have full control over the Styles for their child sites in the network. We're providing eight default Style options that Nonprofits can use as a starting place, which will all meet a11y requirements, but ultimately Site Admins will be able to deviate from the defaults and customization color palettes at will for their sites. GB wants to include an a11y overlay / checker tool so that Site Admins can check that their custom color palettes meet a11y requirements. @nathan-schmidt-viget flagged some limitations here already (e.g., the plugin will flag issues, but won't fix them).
There was a problem hiding this comment.
I agree with Nathan's recommendation for Accessibility Checker. It meets the need of site admins to check their color and content choices. Should that be installed instead of One Click Accessibility? That one is a true overlay that falls into the "not actually useful and potentially harmful" category.
There was a problem hiding this comment.
Yeah the plugin I recommended is kind of like the WAVE tool. It does not fix the issues but will at least flag them. One Click Accessibility does not show issues, but does "helpful" overlay stuff.
As long as we flag GB so they know that One Click Accessibility will not make a site pass A11Y and could make it harder for A11Y.
+1 on what @ten1seven said
There was a problem hiding this comment.
Here's my take on why One Click Accessibility isn't needed:
Add a toolbar toggling hat[sp.] allows you to set:
- Resize font (increase/decrease): users set zoom/font size with global browser and OS settings
- Grayscale: users set screen colors with global browser and OS settings
- Negative Contrast: users set screen contrast with global browser and OS settings
- High Contrast: users set screen contrast with global browser and OS settings
- Light Background: users that need this will have set it for all sites they visit
- Links Underline: we'll ensure that links are visible as links, but users that need this will have set it for all sites they visit
- Readable Font: we'll ensure a readable font size and contrast, but users that need this (like a dyslexia font) will have set it for all sites they visit
- Link to Sitemap / Feedback / Help pages: we'll have these if they apply
Accessibility Features:
- Enable skip to content: we'll build in a skip link
- Add outline focus for focusable elements: we'll have ensured focusable elements have a focus outline
- Remove the target attribute from links: this is more of a content creator awareness issue but "open in new tab" links can slip in with WordPress' WYSIWYG
- Add landmark roles to all links: nice but not critical
- Customizer for style adjustment: it would be good to have a dark mode option for the themes, but this seems similar to the visual settings in the section above
There was a problem hiding this comment.
@nathan-schmidt-viget Just a heads up, I swapped the plugins and saw this message, wanted to document it, we may need to purchase the paid version of this plugin. cc/ @clatwell @shascher
Whoops! It looks like your website is currently password protected. The free version of Accessibility Checker can only scan live websites. To scan this website for accessibility problems either remove the password protection or upgrade to pro. Scan results may be stored from a previous scan.
|
@ten1seven @clatwell @nathan-schmidt-viget I went ahead and re-requested review on this PR, it should be good to go now. (Sorry I didn't have it as DRAFT before!) |
| # Loaded via Composer | ||
| /plugins/advanced-custom-fields-pro/ | ||
| /plugins/cookie-law-info/ | ||
| /plugins/pojo-accessibility/ |
There was a problem hiding this comment.
@bd-viget do you need to remove /plugins/pojo-accessibility/ from .gitignore?
There was a problem hiding this comment.
I didn't see any harm leaving it in here, just in case the GB team decides to push back on a different plugin. Tagging ticket #55 to remove this if necessary.
|
|
||
| /** | ||
| * Save ACF JSON to the plugin directory, but only when developing locally. | ||
| * We don't want to break this feature if the non-profit is using ACF. |
There was a problem hiding this comment.
Is it possible that an individual non-profit could install ACF on their site? Are you allowing that level of customization?
There was a problem hiding this comment.
ACF will be installed and active across all sites, so they potentially could use it with a custom theme down the road.
Summary
This PR enables the ability to load plugins via
composerand defines a few initial plugins:Usage instructions have been added to the README.
This PR also includes some of the requirements for WP VIP and ACF.
Issues
Related Issues