Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#90] GB and Privacy Policy page #118

Merged
merged 7 commits into from
Jan 3, 2024
Merged

Conversation

nathan-schmidt-viget
Copy link
Contributor

Summary

This added the main site name to the footer as well as the Privacy page link.
It makes both of these dynamic to they can be updated in the main site admin.

The Terms & Conditions will be hooked up once we get the plugin installed and set up.

Issues

Testing Instructions

  • Go to the front end of the main site and make sure the footer is pulling text and links into the footer
  • Go to Settings -> General and update the Main Site Title and Tag line. Save your changes.
  • Go back to the front end and make sure your edits are reflected in the footer.
  • Set a page for the privacy page. Go to Settings -> Privacy.
  • Set a page to be the Privacy page. Save your changes.
  • Check the front end and make sure the title and link are updated in the privacy link.

Screenshots

Screenshot 2023-12-22 at 10 28 52 AM

@nathan-schmidt-viget nathan-schmidt-viget marked this pull request as ready for review December 22, 2023 18:14
Copy link
Contributor

@bd-viget bd-viget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're making fantastic progress with these i18n and escaping functions (and could quite possibly the most confusing part of WordPress development)! I added some comments that hopefully bring a bit more clarity to these, but feel free to hit me up if it's not making sense.

client-mu-plugins/goodbids/blocks/main-footer/block.php Outdated Show resolved Hide resolved
client-mu-plugins/goodbids/blocks/main-footer/block.php Outdated Show resolved Hide resolved
client-mu-plugins/goodbids/blocks/main-footer/block.php Outdated Show resolved Hide resolved
client-mu-plugins/goodbids/blocks/main-footer/block.php Outdated Show resolved Hide resolved
client-mu-plugins/goodbids/blocks/main-footer/render.php Outdated Show resolved Hide resolved
client-mu-plugins/goodbids/blocks/main-footer/render.php Outdated Show resolved Hide resolved
client-mu-plugins/goodbids/blocks/main-footer/render.php Outdated Show resolved Hide resolved
client-mu-plugins/goodbids/blocks/main-footer/render.php Outdated Show resolved Hide resolved
Copy link
Contributor

@bd-viget bd-viget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna go ahead and approve so it's not a blocker, but just need that one update I mentioned in the related comment. Nice work!

client-mu-plugins/goodbids/blocks/main-footer/render.php Outdated Show resolved Hide resolved
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bd-viget Got phpbf and phpcs working again!

@nathan-schmidt-viget nathan-schmidt-viget merged commit 26c997d into main Jan 3, 2024
1 check passed
@nathan-schmidt-viget nathan-schmidt-viget deleted the ns/90-tc-pp-pages branch January 3, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants