-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#90] GB and Privacy Policy page #118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're making fantastic progress with these i18n and escaping functions (and could quite possibly the most confusing part of WordPress development)! I added some comments that hopefully bring a bit more clarity to these, but feel free to hit me up if it's not making sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gonna go ahead and approve so it's not a blocker, but just need that one update I mentioned in the related comment. Nice work!
2e48dca
to
c336789
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bd-viget Got phpbf and phpcs working again!
Summary
This added the main site name to the footer as well as the Privacy page link.
It makes both of these dynamic to they can be updated in the main site admin.
The Terms & Conditions will be hooked up once we get the plugin installed and set up.
Issues
Testing Instructions
Screenshots