Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a PHP error. #113

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Fix a PHP error. #113

merged 2 commits into from
Dec 21, 2023

Conversation

bd-viget
Copy link
Contributor

Summary

This PR fixes 2 PHP errors.

Issues

N/A

@bd-viget bd-viget merged commit eb3a604 into main Dec 21, 2023
1 check passed
@bd-viget bd-viget deleted the bd/hotfix-php-errors branch December 21, 2023 14:41
Copy link
Contributor

@nathan-schmidt-viget nathan-schmidt-viget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Comment on lines +11 to 14
$goal = goodbids()->auctions->get_goal();
$estimated_value = goodbids()->auctions->get_estimated_value();
$expected_high_bid = goodbids()->auctions->get_expected_high_bid();
?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, I think I was confused in how that worked. Do we need to update Reward Product Gallery as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that block was fine

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants