Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectionView #64

Merged
merged 3 commits into from
Jan 30, 2023
Merged

Conversation

yy0867
Copy link
Collaborator

@yy0867 yy0867 commented Jan 28, 2023

작업 내용

질문 및 특이사항

원래는 아예 감정으로 고정해서 구현하려고 했으나
그렇게 하면 UI Framework에서 Emotion이라는 모델을 필요로 하게 됩니다.
따라서 DataSource에서 각 Item의 이미지와 타이틀을 설정할 수 있도록 구현하였습니다.

또한 Delegate를 통해 선택된 Item의 row, column 정보를 얻어올 수 있습니다.

Image가 모두 UI Framework에 들어가 있어서, 만약 Tuist에서 생성된 GongGanGam UI Asset을 사용하지 않는다면
Item의 각 표정 Image를 가져올 때 Bundle에 주의해야 합니다.

2023-01-28.15.25.45.mov

체크리스트

  • 빌드가 되는 코드인가요?
  • Warning이 없는 코드인가요?
  • Merge할 브랜치가 올바른가요?
  • 코딩 컨벤션이 올바른가요?

@yy0867 yy0867 added the 💄 Style 뷰 관련 label Jan 28, 2023
@yy0867 yy0867 self-assigned this Jan 28, 2023
Copy link
Contributor

@chansooo chansooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yy0867 yy0867 merged commit e19f09d into feature/ui-framework Jan 30, 2023
@yy0867 yy0867 deleted the feature/ui-framework-select-emotion-view branch January 30, 2023 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💄 Style 뷰 관련
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants