-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TitledView, TitledTextField #60
TitledView, TitledTextField #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
/// Title label of `TitledView`. | ||
/// Based on `UILabel` | ||
/// | ||
/// - default font: `Pretendard.Body(400)` | ||
/// - default textColor: `Neutral-10` | ||
/// | ||
/// 이 label의 `text`를 변경하여 `TitledView`의 타이틀을 설정할 수 있습니다. | ||
public lazy var titleLabel: UILabel = { | ||
let label = UILabel() | ||
|
||
label.font = Pretendard.body | ||
label.textColor = GongGanGamUIAsset.neutral10.color | ||
return label | ||
}() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
titleLabel의 text만 변경되고 나머지 속성값들은 변경될 일이 없다면 해당 Label을 private하게 두고
setTitleLabelText(_ text: String) 같은 함수로 text를 변경하는 건 어떨까용?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
text를 제외하고도 font나 color 등의 여러 색상이 변경될 여지가 있다고 판단해서 public으로 두었습니다..!
작업 내용
질문 및 특이사항
테스트할 때 메인 타겟의 SceneDelegate를 다음과 같이 작성합니다.
체크리스트