Skip to content

Commit

Permalink
Updated Catchrate Info, Bugfix German Localization
Browse files Browse the repository at this point in the history
* The catch rate will now update correctly if your Fishing Skill level up
* Fixed a bug in the german localization (catch rate didn't show up correctly in Alterac Mountains)
* Little updates inside the toc file
  • Loading branch information
Godot-Fye authored Dec 27, 2019
1 parent 47c0505 commit c361508
Show file tree
Hide file tree
Showing 3 changed files with 45 additions and 4 deletions.
4 changes: 2 additions & 2 deletions Fishbringer.toc
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
## Notes: The legendary Fishbringer, Guide of the Scarlet Highlord! Nat Pagle would be proud of you!
## Notes-deDE: Das legendäre Fishbringer, Leitfaden des Scharlachroten Hochlords! Nat Pagle wäre stolz auf dich!
## Notes-ruRU: The legendary Fishbringer, Guide of the Scarlet Highlord! Nat Pagle would be proud of you!
## Author: Kalerath, Fye (German Localization), leafoe (Russian Localization)
## Author: Kalerath, Fye (Localization Code & Bugfixes), leafoe (Russian Localization)
## SavedVariables: FishbringerDB
## Version: 1.13-3
## Version: 1.13-4

localization.core.lua
Localization.deDE.lua
Expand Down
2 changes: 1 addition & 1 deletion Localization.deDE.lua
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ if namespace.locale == "deDE" then
L["Redridge Mountains"] = "Rotkammgebirge"
L["Stonetalon Mountains"] = "Steinkrallengebirge"
L["Wetlands"] = "Sumpfland"
L["Alterac Mountains"] = "Alteractal"
L["Alterac Mountains"] = "Alteracgebirge"
L["Arathi Highlands"] = "Arathihochland"
L["Desolace"] = "Desolace"
L["Dustwallow Marsh"] = "Marschen von Dustwallow"
Expand Down
43 changes: 42 additions & 1 deletion fishy.lua
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,7 @@ local function UpdateSkill(forceResetFishCounter)
if forceResetFishCounter or db[char].fishingSkill ~= skillRank then
db[char].fishingSkill = skillRank
ResetFishCounter(fishNeeded)
UpdateCatchInfo()
end

if db[char].fishingBuff ~= skillModifier then
Expand Down Expand Up @@ -466,6 +467,44 @@ local function ShowHelp()
Print(L["- /fishbringer align - Cycles through text alignment."])
Print(L["- /fishbringer count - Toggles fish count visibility."])
Print(L["- /fishbringer reset - Resets the fish database."])

--[[local FishbringerUI = {}
local FishbringerUI = CreateFrame("Frame", "FishbringerUI", UIParent, "BasicFrameTemplateWithInset")
FishbringerUI:SetSize(300, 400);
FishbringerUI:SetPoint("Center", UIParent, "Center");
FishbringerUI:EnableMouse(true);
FishbringerUI:SetMovable(true);
FishbringerUI:RegisterForDrag("LeftButton")
FishbringerUI:SetScript("OnDragStart", FishbringerUI.StartMoving)
FishbringerUI:SetScript("OnDragStop", FishbringerUI.StopMovingOrSizing)
FishbringerUI:Show();
FishbringerUI.title = FishbringerUI:CreateFontString(nil, "Overlay");
FishbringerUI.title:SetFontObject("GameFontHighlight");
FishbringerUI.title:SetPoint("Center", FishbringerUI.TitleBg, "Center", 5, 0);
FishbringerUI.title:SetText("|cFF00FF00Fishbringer v1.13.4");
MoveableWindowButton = CreateFrame("CheckButton", "MoveableWindowButton_GlobalName", FishbringerUI, "ChatConfigCheckButtonTemplate");
MoveableWindowButton:SetPoint("TOPLEFT", 10, -60);
MoveableWindowButton_GlobalNameText:SetText("Window Moveable");
MoveableWindowButton.tooltip = "Let's move the Window...or not?";
MoveableWindowButton:SetScript("OnClick",
function()
--FishbringerUI:SetMovable(false)
end
);
ToggleButton = CreateFrame("CheckButton", "ToggleButton_GlobalName", FishbringerUI, "ChatConfigCheckButtonTemplate");
ToggleButton:SetPoint("TOPLEFT", 10, -30);
ToggleButton_GlobalNameText:SetText("Show/Hide the Fishing Widget");
ToggleButton.tooltip = "Toggles the Widget visibility.";
ToggleButton:SetScript("OnClick",
function()
Toggle();
end
); --]]

end

SlashCmdList["FISHBRINGER"] = function(arg)
Expand All @@ -483,9 +522,11 @@ SlashCmdList["FISHBRINGER"] = function(arg)
end
return ShowHelp()
end

SLASH_FISHBRINGER1 = "/fishbringer"
-- Hail to Fishing Buddy!
if not select(4, GetAddOnInfo"Fishing Buddy") then
if not select(4, GetAddOnInfo"FishingBuddy") then
SLASH_FISHBRINGER2 = "/fb"
end

Print(L["Pack yer bags, we be leavin' fer fishin'!"])

0 comments on commit c361508

Please sign in to comment.