Feature/show relation (#46)

* ShowRelation to print out the relation expression * docs * split not array_sort * missed ignoreNulls parameter - defaults to false
GoEddie · Dec 3, 2024 · b63f65a · b63f65a
1 parent cfc248b
commit b63f65a
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/src/Spark.Connect.Dotnet/Spark.Connect.Dotnet/Sql/ManualFunctions.cs b/src/Spark.Connect.Dotnet/Spark.Connect.Dotnet/Sql/ManualFunctions.cs
@@ -1257,24 +1257,24 @@ public static Column DateTrunc(string format, string timestamp)
         return new Column(CreateExpression("date_trunc", false, Lit(format), Col(timestamp)));
     }
 
-    public static Column First(string col)
+    public static Column First(string col, bool ignoreNulls = false)
     {
-        return new Column(CreateExpression("first", false, Col(col)));
+        return new Column(CreateExpression("first", false, Col(col), Lit(ignoreNulls)));
     }
 
-    public static Column First(Column col)
+    public static Column First(Column col, bool ignoreNulls = false)
     {
-        return new Column(CreateExpression("first", false, col));
+        return new Column(CreateExpression("first", false, col, Lit(ignoreNulls)));
     }
 
-    public static Column Last(Column col)
+    public static Column Last(Column col, bool ignoreNulls = false)
     {
-        return new Column(CreateExpression("last", false, col));
+        return new Column(CreateExpression("last", false, col, Lit(ignoreNulls)));
     }
 
-    public static Column Last(string col)
+    public static Column Last(string col, bool ignoreNulls = false)
     {
-        return new Column(CreateExpression("last", false, Col(col)));
+        return new Column(CreateExpression("last", false, Col(col), Lit(ignoreNulls)));
     }
 
     public static Column FormatString(string format, params Column[] cols)
@@ -2169,7 +2169,7 @@ public static Column Split(Column str, string pattern, int? limit = null)
             return new Column(CreateExpression("split", false, str, Lit(pattern), Lit(limit.Value)));
         }
 
-        return new Column(CreateExpression("sort_array", false, str, Lit(pattern)));
+        return new Column(CreateExpression("split", false, str, Lit(pattern)));
     }
 
     public static Column Split(string str, string pattern, int? limit = null)