Fix invalid-$DISPLAY error being non-text #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zopsicle
reviewed
Apr 6, 2024
gnucash/gnucash.cpp
Outdated
| @@ -296,7 +296,7 @@ main(int argc, char ** argv) | |||
| << "\n" | |||
| // Translators: Do not translate $DISPLAY! It is an environment variable for X11 | |||
| << _("Error: could not initialize graphical user interface and option add-price-quotes was not set.\n" | |||
| "Perhaps you need to set the $DISPLAY environment variable?"); | |||
| "Perhaps you need to set the $DISPLAY environment variable?\n"); | |||
There was a problem hiding this comment.
weird workaround instead of correct solution, breaks some existing translations
There was a problem hiding this comment.
What's weird about @chloekek 's suggestion ? That's perfectly normal c++ and it avoids having to add coded newline characters in translations. Note how line 296 does exactly the same thing.
As for breaking existing translations, so does your proposal 😉 albeit the exact opposite set of translations. You even added fixes for them in your PR.
I'd be tempted to go with @chloekek 's suggestion.
Given nabijaczleweli@tarta:~$ DISPLAY=komputerek-x40.:0 gnucash Run 'g --help' to see a full list of available command line options. Error: could not initialise graphical user interface and option add-price-quotes was not set. Perhaps you need to set the $DISPLAY environment variable?nabijaczleweli@tarta:~$ we can obviously see the error output isn't a text file.
|
applied |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given
Half-mechanically updated with
and then
vi $(git grep -l 'eed to set the $DISPLAY environmen')