Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symlinking on deploys & Rollback functionality #8

Merged
merged 12 commits into from
Apr 17, 2021

Conversation

AdamHebby
Copy link
Contributor

My IDE also removes tailing spaces, which ansible-lint also classifies as an invalid thing

Anyway.

Changes:

  • Adds 3 states of the web: new, current (symlinked to new), old
  • Reduces downtime by moving service stop to last possible moment, right before the symlink
  • Adds Rollback functionality & new playbook to do so

Tests:
Ideally, this would be tested on a real server, but I don't think that's possible?

Issues fixed:
#7
#3

@clone1018
Copy link
Member

Sorry for the delay in review this, we've actually been using it in production for a bit :)

It's a great change, thank you for working on it! The one problem I noticed is old deploys are not being cleaned up like they should be. Let me know if you need help debugging!

@clone1018 clone1018 merged commit a0f30ac into Glimesh:main Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants