Enable playout-delay extension + NACKs + janus version bumps #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not meant to merge as-is, but I wanted a place to coordinate rolling out the janus-ftl-plugin changes I've been making and we've been discussing over on Glimesh/janus-ftl-plugin#135.(edit: those changes have merged) This follows my original plan in Glimesh/janus-ftl-plugin#126 (comment)This specifically targets what changes need to happen to turn on the playout-delay extension from Glimesh/janus-ftl-plugin#134, because it involves a few things:
janus_playout_delay_support=true
I totally support your idea to deploy this to just one server to start with (note playout-delay is only meaningful on edge servers though). After deploying I'd want to verify:
chrome://webrtc-internals/
, the value ofjitterBufferDelay/jitterBufferEmittedCount_in_ms
should never really dip below the configured min playout delayWhile this does implicitly bump the janus version and libsrtp version, there was not impact I saw or expected from that, just keeping up with dependencies.