Docker cleanup #45
Merged
Docker cleanup #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haydenmc
reviewed
Dec 7, 2020
| @@ -77,7 +77,7 @@ Configuration is achieved through environment variables. | |||
|
|
|||
| # Dockering | |||
|
|
|||
| docker build -t janus-ftl | |||
| docker build -t janus-ftl . | |||
| docker run --rm -p 8084:8084/tcp -p 8088:8088/tcp -p 9000-9100:9000-9100/udp -p 20000-20100:20000-20100/udp -e "DOCKER_IP=HOST.IP.ADDRESS.HERE" janus-ftl | |||
There was a problem hiding this comment.
We ought to just tell folks to use host networking at this point, due to moby/moby#14288
danstiner
force-pushed
the
docker-cleanup
branch
from
8f93af9 to
c9be260
Compare
|
Verified this works locally for me and builds slightly faster. Not going to update host networking instructions because I haven't tested that yet. |
|
Sorry for the delay :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have yet to test janus still works but it at least still compiles.
Once I test I'll update this and update the readme so #32 can be called complete.